fix(ai-accounts): neutralise the quota bar fill, not just its text - #937
Merged
Conversation
#936 neutralised percentClass, chipClass and chipLabelClass, but the card view renders quota through renderQuotaBarNode, which uses none of them except the percent: it consumes fillClass and paints it as the row's own background rather than a slim track underneath. At 100% that fill covers the entire line, so every healthy window still rendered as a green band and the card read exactly as before. Move fillClass to neutral slate for the >= 60% branch. fillHex keeps its emerald: it drives the 14px progress ring in QuotaMetricChips, where the colour occupies a ring instead of a row. Amber and rose fills are left alone, so a bar that changes colour now means something changed. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #936. Panel-only.
What #936 missed
#936 neutralised
percentClass,chipClassandchipLabelClass. Verified on production after deploy, the card still rendered as a green band:The card view renders quota through
renderQuotaBarNode, notQuotaMetricChipsβ there is noauth-file-quota-metricnode on the page at all. It consumes exactly one field from the tone,fillClass, and paints it as the row's own background rather than a slim track underneath. At 100% that fill covers the entire line, so the row was still fully green no matter what colour the label and percent were.The change
fillClassmoves to neutral slate for the β₯60% branch.fillHexkeeps its emerald β that one drives the 14px progress ring inQuotaMetricChips, where the colour occupies a ring instead of a whole row.Amber (20β60%) and rose (<20%) fills are untouched, so a bar that changes colour now means something actually changed.
Verified
Patched the class live on production and re-screenshotted: the three quota rows drop to neutral, and the card reads as a normal card. What #936 already fixed and this PR does not touch: subscription badge (
ε©δ½ 6 倩) and success rate (99.7%) both render neutral on production now.Gates:
design:checkβ Β·size:checkβ Β·surface:checkβ Β·lint0 errors β Β· 243 tests / 21 files βπ€ Generated with Claude Code